-
Notifications
You must be signed in to change notification settings - Fork 15
Deprecate iter_named_leaf_modules
and iter_named_quantizable_modules
#381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
iter_named_leaf_modules
and iter_named_quantizable_modules
iter_named_leaf_modules
and iter_named_quantizable_modules
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
This reverts commit 9b23a62.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
discussed with @kylesayrs that mapping all iter_named_leaf_modules
, regardless of whether include_attn
/include_children
are False or True, to torch built-in .named_modules()
method, should not affect overall behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…es` (#1628) ## Purpose ## * Refactor module targeting to be cleaner and easier to maintain * Support skipping `TransformBase` modules ## Prerequisites ## * neuralmagic/compressed-tensors#381 ## Changes ## * Remove all uses of `iter_named_leaf_modules` and `iter_named_quantizable_modules` * Make `Observer` inherit from `InternalModule` ## Testing ## * https://github.com/neuralmagic/llm-compressor-testing/actions/runs/16123598340 ✅ --------- Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Purpose
TransformBase
modulesPrerequisites
iter_named_leaf_modules
anditer_named_quantizable_modules
vllm-project/llm-compressor#1628Changes
iter_named_leaf_modules
anditer_named_quantizable_modules
model.modules()
. Infact, they're likely significantly slowerUntargetableModule
classObserver
andTransformBase
inherit from this classTODO
Testing